Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add accent color support for macOS #589

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

dan-lee
Copy link

@dan-lee dan-lee commented Oct 14, 2022

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

Similar to the theme support this adds support for the accent color for macOS.
I added this as Electron offers something similar (or as an event).

I don't have Windows at hand, but this could potentially be added in the future for Windows as well.

Affected system setting:

image

@dan-lee dan-lee requested a review from a team as a code owner October 14, 2022 09:13
@Ynng
Copy link

Ynng commented Aug 29, 2024

Would be so cool to have this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants