refactor(bundler): output file name consistency, closes #10465 #10577
Conversation
Package Changes Through a9af8ccThere are 7 changes which include tauri-build with prepatch, tauri-codegen with prerelease, tauri-utils with prerelease, tauri-cli with prerelease, @tauri-apps/cli with prerelease, tauri with prerelease, tauri-bundler with prerelease Planned Package VersionsThe following package releases are the planned based on the context of changes in this pull request.
Add another change file through the GitHub UI by following this link. Read about change files or the docs at github.com/jbolda/covector |
| language, | ||
| ); | ||
| let msi_name = | ||
| crate::bundle::bundle_name_with_suffix(settings, &language.replace('-', "_"), "msi"); |
There was a problem hiding this comment.
we should probably revert this change, - (hyphen) is the separator in language tags per the IETF standard https://en.wikipedia.org/wiki/IETF_language_tag#Syntax_of_language_tags
There was a problem hiding this comment.
well that's true, but with this change it's also the separator for the parts in the bundle file name.. I'd prefer using _ instead, but some people prefer -
There was a problem hiding this comment.
there will always people wanting it the other way around but I don't see an issue with App-1.2.0-x64-en-US.exe, seems better than App-1.2.0-x64-en_US.exe
Co-authored-by: Amr Bashir <[email protected]>
Co-authored-by: Amr Bashir <[email protected]>
Co-authored-by: Amr Bashir <[email protected]>
|
let's at least hold on merging this one, must be communicated (ideally released as the last RC or perhaps even the first 2.0 stable release) |
|
This is missing explicit Arm + AppImage support - noticed because of #10619 (arm64 currently works, but i apparently didn't test arm 32bit which doesn't work). Expanding this condition for arm->armhf should be enough i think https://github.com/tauri-apps/tauri/blob/dev/tooling/bundler/src/bundle/linux/templates/appimage#L14 |
| @@ -30,27 +28,26 @@ pub fn bundle_project(settings: &Settings) -> crate::Result<Vec<PathBuf>> { | |||
|
|
|||
| let summary = settings.short_description().trim(); | |||
|
|
|||
| let package_base_name = format!("{product_name}-{version}-{release}.{arch}"); | |||
| let package_name = format!("{package_base_name}.rpm"); | |||
| let rpm_name = crate::bundle::bundle_name_with_suffix(settings, release, "dmg"); | |||
There was a problem hiding this comment.
| let rpm_name = crate::bundle::bundle_name_with_suffix(settings, release, "dmg"); | |
| let rpm_name = crate::bundle::bundle_name_with_suffix(settings, release, "rpm"); |
I'm still not sure if we want to keep the release tag in the RPM file name, but I'll keep it for now.
Mainly wanted to raise awareness on this issue first.
I like the consistency of this, but I'm also not really a fan of using
-instead of_as separator.Note that
-is also the separator used on the language string currently appended to the MSI file name. I think I'll just change that to use_instead.