Run CI tests with Node 19

* Update Test262 to latest Node19-compatible tests
* Update GH actions to latest versions
* Test262 against Node 14, 16, 18, and 19
* Use Node19 on all other actions and tests
* Extend expected-failures.txt handling so some tests can be expected
  to fail only on some Node versions.

.github/workflows/deploy.yml

@@ -7,18 +7,18 @@ jobs:
   deploy:
     runs-on: ubuntu-latest
     steps:
-    - uses: actions/checkout@v2
-      with:
-        persist-credentials: false
-    - name: use node.js v15.x
-      uses: actions/setup-node@v1
-      with:
-        node-version: 15.x
-    - run: npm ci
-    - run: npm run build
-    - uses: JamesIves/[email protected]
-      with:
-        GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
-        BRANCH: gh-pages
-        FOLDER: out
-        CLEAN: true
+      - uses: actions/checkout@v3
+        with:
+          persist-credentials: false
+      - name: use node.js v19.x
+        uses: actions/setup-node@v3
+        with:
+          node-version: 19.x
+      - run: npm ci
+      - run: npm run build
+      - uses: JamesIves/[email protected]
+        with:
+          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+          BRANCH: gh-pages
+          FOLDER: out
+          CLEAN: true

.github/workflows/lint.yml

@@ -4,11 +4,11 @@ jobs:
   lint:
     runs-on: ubuntu-latest
     steps:
-    - uses: actions/checkout@v2
-    - name: use node.js v15.x
-      uses: actions/setup-node@v1
-      with:
-        node-version: 15.x
-    - run: npm ci
-    - run: npm run lint
-    - run: npm run build:spec
+      - uses: actions/checkout@v2
+      - name: use node.js v19.x
+        uses: actions/setup-node@v1
+        with:
+          node-version: 19.x
+      - run: npm ci
+      - run: npm run lint
+      - run: npm run build:spec

.github/workflows/test.yml

@@ -5,50 +5,92 @@ on:
     branches:
       - main
 jobs:
-  test-polyfill:
+  test-demitasse:
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v2
-      - name: use node.js v18.x
-        uses: actions/setup-node@v1
+      - uses: actions/checkout@v3
+      - name: use node.js v19.x
+        uses: actions/setup-node@v3
         with:
-          node-version: 18.x
+          node-version: 19.x
       - run: npm ci
       - run: npm run test-demitasse
         env:
           HEAD_SHA: ${{ github.event.pull_request.head.sha }}
-  test-test262:
+  test-test262-node19:
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v2
+      - uses: actions/checkout@v3
+        with:
+          submodules: true
+      - name: use node.js v19.x
+        uses: actions/setup-node@v3
+        with:
+          node-version: 19.x
+      - run: npm ci
+      - run: npm run codecov:test262
+        env:
+          HEAD_SHA: ${{ github.event.pull_request.head.sha }}
+  test-test262-node18:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v3
         with:
           submodules: true
       - name: use node.js v18.x
-        uses: actions/setup-node@v1
+        uses: actions/setup-node@v3
         with:
           node-version: 18.x
       - run: npm ci
       - run: npm run codecov:test262
         env:
           HEAD_SHA: ${{ github.event.pull_request.head.sha }}
+  test-test262-node16:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v3
+        with:
+          submodules: true
+      - name: use node.js v16.x
+        uses: actions/setup-node@v3
+        with:
+          node-version: 16.x
+      - run: npm ci
+      - run: npm run codecov:test262
+        env:
+          HEAD_SHA: ${{ github.event.pull_request.head.sha }}
+  test-test262-node14:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v3
+        with:
+          submodules: true
+      - name: use node.js v14.x
+        uses: actions/setup-node@v3
+        with:
+          node-version: 14.x
+      - run: npm ci
+      - run: npm run codecov:test262
+        env:
+          HEAD_SHA: ${{ github.event.pull_request.head.sha }}
   test-cookbook:
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v2
-      - name: use node.js v18.x
-        uses: actions/setup-node@v1
+      - uses: actions/checkout@v3
+      - name: use node.js v19.x
+        uses: actions/setup-node@v3
         with:
-          node-version: 18.x
+          node-version: 19.x
       - run: npm ci
       - run: npm run test-cookbook
   test-validstrings:
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v2
-      - name: use node.js v18.x
-        uses: actions/setup-node@v1
+      - uses: actions/checkout@v3
+      - name: use node.js v19.x
+        uses: actions/setup-node@v3
         with:
-          node-version: 18.x
+          node-version: 19.x
       - run: npm ci
       - run: |
           cd polyfill

polyfill/runtest262.mjs

@@ -64,12 +64,25 @@ const polyfillCode = fs.readFileSync('script.js', UTF8);
 const polyfill = new vm.Script(polyfillCode, { filename: path.resolve('script.js') });
 
 // Read the expected failures file and put the paths into a Set
+// If a Node version is provided in a line, that's the minimum major version
+// where the test is expected to pass. If the current Node version is equal to
+// or greater, then it's not an expected failure here.
 
+const nodeVersion = parseInt(process.versions.node.split('.')[0]);
 const expectedFailures = new Set(
   fs
     .readFileSync('test/expected-failures.txt', UTF8)
     .split(/\r?\n/g)
-    .filter((line) => line && line[0] !== '#')
+    .filter((line) => {
+      if (!line) return false;
+      if (line[0] === '#') return false;
+
+      // Is it expected to fail in this Node version?
+      const [, minNodeVersion] = line.split(' ');
+      if (minNodeVersion && nodeVersion >= parseInt(minNodeVersion)) return false;
+      return true;
+    })
+    .map((line) => line.split(' ')[0])
 );
 
 // This function reads in a test262 harness helper file, specified in 'includes'
@@ -268,7 +281,7 @@ print(`\n${total} tests finished in ${color.bold(elapsed.toFixed(1))} s`);
 print(color.green(`  ${passCount} passed`));
 print(color.red(`  ${failures.length} failed`));
 if (expectedFailCount > 0) {
-  print(color.cyan(`  ${expectedFailCount} expected failures`));
+  print(color.cyan(`  ${expectedFailCount} expected failure${expectedFailCount === 1 ? '' : 's'}`));
 }
 
 process.exit(failures.length > 0 ? 1 : 0);

polyfill/test/expected-failures.txt

@@ -1,2 +1,20 @@
+# expected failures unrelated to Node versions
 intl402/Temporal/TimeZone/prototype/getNextTransition/transition-at-instant-boundaries.js
 intl402/Temporal/TimeZone/prototype/getPreviousTransition/transition-at-instant-boundaries.js
+
+# Intl.supportedValuesOf("timeZone") is only available starting in Node 18
+intl402/Temporal/TimeZone/supported-values-of.js 18
+
+# Before Node 16, dateStyle/timeStyle options didn't conflict with other options
+intl402/Temporal/Instant/prototype/toLocaleString/options-conflict.js 16
+intl402/Temporal/PlainDate/prototype/toLocaleString/options-conflict.js 16
+intl402/Temporal/PlainDateTime/prototype/toLocaleString/options-conflict.js 16
+intl402/Temporal/PlainTime/prototype/toLocaleString/options-conflict.js 16
+intl402/Temporal/ZonedDateTime/prototype/toLocaleString/options-conflict.js 16
+
+# Before Node 16, calling an uncallable value seems to throw a RangeError, not a TypeError
+intl402/Temporal/PlainYearMonth/prototype/toLocaleString/timezone-getoffsetnanosecondsfor-not-callable.js 16
+intl402/Temporal/PlainMonthDay/prototype/toLocaleString/timezone-getoffsetnanosecondsfor-not-callable.js 16
+intl402/Temporal/PlainDate/prototype/toLocaleString/timezone-getoffsetnanosecondsfor-not-callable.js 16
+intl402/Temporal/PlainDateTime/prototype/toLocaleString/timezone-getoffsetnanosecondsfor-not-callable.js 16
+intl402/Temporal/PlainTime/prototype/toLocaleString/timezone-getoffsetnanosecondsfor-not-callable.js 16