Skip to content

Commit

Permalink
Run CI tests with Node 19 / CLDR 42
Browse files Browse the repository at this point in the history
* Updates GH actions to latest versions
* Uses Node19 for all actions and tests
* Updates @js-temporal/temporal-test262-runner lib
* Includes a few Temporal-related DateTimeFormat Test262 tests
  to the CI codecov script.
* Updates Test262 to include tc39/test262#3762
  so that additional DateTimeFormat tests will pass.
  • Loading branch information
justingrant committed Jan 11, 2023
1 parent 4664de5 commit 7b78da5
Show file tree
Hide file tree
Showing 6 changed files with 48 additions and 41 deletions.
30 changes: 15 additions & 15 deletions .github/workflows/deploy.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,18 +7,18 @@ jobs:
deploy:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
with:
persist-credentials: false
- name: use node.js v15.x
uses: actions/setup-node@v1
with:
node-version: 15.x
- run: npm ci
- run: npm run build
- uses: JamesIves/[email protected]
with:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
BRANCH: gh-pages
FOLDER: out
CLEAN: true
- uses: actions/checkout@v3
with:
persist-credentials: false
- name: use node.js v19.x
uses: actions/setup-node@v3
with:
node-version: 19.x
- run: npm ci
- run: npm run build
- uses: JamesIves/[email protected]
with:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
BRANCH: gh-pages
FOLDER: out
CLEAN: true
16 changes: 8 additions & 8 deletions .github/workflows/lint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,11 +4,11 @@ jobs:
lint:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- name: use node.js v15.x
uses: actions/setup-node@v1
with:
node-version: 15.x
- run: npm ci
- run: npm run lint
- run: npm run build:spec
- uses: actions/checkout@v3
- name: use node.js v19.x
uses: actions/setup-node@v3
with:
node-version: 19.x
- run: npm ci
- run: npm run lint
- run: npm run build:spec
32 changes: 16 additions & 16 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,47 +8,47 @@ jobs:
test-polyfill:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- name: use node.js v18.x
uses: actions/setup-node@v1
- uses: actions/checkout@v3
- name: use node.js v19.x
uses: actions/setup-node@v3
with:
node-version: 18.x
node-version: 19.x
- run: npm ci
- run: npm run test-demitasse
env:
HEAD_SHA: ${{ github.event.pull_request.head.sha }}
test-test262:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v3
with:
submodules: true
- name: use node.js v18.x
uses: actions/setup-node@v1
- name: use node.js v19.x
uses: actions/setup-node@v3
with:
node-version: 18.x
node-version: 19.x
- run: npm ci
- run: npm run codecov:test262
env:
HEAD_SHA: ${{ github.event.pull_request.head.sha }}
test-cookbook:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- name: use node.js v18.x
uses: actions/setup-node@v1
- uses: actions/checkout@v3
- name: use node.js v19.x
uses: actions/setup-node@v3
with:
node-version: 18.x
node-version: 19.x
- run: npm ci
- run: npm run test-cookbook
test-validstrings:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- name: use node.js v18.x
uses: actions/setup-node@v1
- uses: actions/checkout@v3
- name: use node.js v19.x
uses: actions/setup-node@v3
with:
node-version: 18.x
node-version: 19.x
- run: npm ci
- run: |
cd polyfill
Expand Down
7 changes: 7 additions & 0 deletions polyfill/ci_codecov_test262.sh
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,13 @@ for subdir in $subdirs; do
node runtest262.mjs "$subdir/**" || failed=1
done
node runtest262.mjs "test262/test/staging/Intl402/Temporal/**/*.js" || failed=1
node runtest262.mjs "test262/test/intl402/**/*[tT]emporal*.js" || failed=1
# TODO: remove the line above and uncomment the three lines below to run tests for all localilzed
# date formatting, because the Temporal polyfill replaces the entire DateTimeFormat object.
# See https://github.com/tc39/proposal-temporal/issues/2471 for more info.
# node runtest262.mjs "test262/test/intl402/DateTimeFormat/**/*.js" || failed=1
# node runtest262.mjs "test262/test/intl402/Intl/DateTimeFormat/**/*.js" || [ $? = 66 ] || failed=1
# node runtest262.mjs "test262/test/built-ins/Date/*/toLocale*String/*.js" || failed=1

c8 report --reporter=text-lcov --temp-directory=$NODE_V8_COVERAGE \
--exclude=polyfill/runtest262.mjs \
Expand Down
2 changes: 1 addition & 1 deletion polyfill/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@
"devDependencies": {
"@babel/core": "^7.17.5",
"@babel/preset-env": "^7.16.11",
"@js-temporal/temporal-test262-runner": "^0.6.0",
"@js-temporal/temporal-test262-runner": "^0.7.0",
"@pipobscure/demitasse": "^1.0.10",
"@pipobscure/demitasse-pretty": "^1.0.10",
"@pipobscure/demitasse-run": "^1.0.10",
Expand Down

0 comments on commit 7b78da5

Please sign in to comment.