Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP - Please ignore - Node 19 intl repro #2450

Closed
wants to merge 2 commits into from

Conversation

justingrant
Copy link
Collaborator

This is a test PR to try to repro a Node 19 issue that shows up in CI running Node 19.2.0 but not on my local Node 19.2.0 install.

For now, please ignore.

@codecov
Copy link

codecov bot commented Dec 16, 2022

Codecov Report

Merging #2450 (7774bfe) into main (4211309) will decrease coverage by 0.31%.
The diff coverage is n/a.

❗ Current head 7774bfe differs from pull request most recent head ace3b2d. Consider uploading reports for the commit ace3b2d to get more accurate results

@@            Coverage Diff             @@
##             main    #2450      +/-   ##
==========================================
- Coverage   94.65%   94.34%   -0.32%     
==========================================
  Files          20       20              
  Lines       11152    11152              
  Branches     1979     1950      -29     
==========================================
- Hits        10556    10521      -35     
- Misses        548      591      +43     
+ Partials       48       40       -8     
Impacted Files Coverage Δ
polyfill/lib/intl.mjs 88.93% <0.00%> (-8.90%) ⬇️
polyfill/lib/calendar.mjs 81.34% <0.00%> (-0.10%) ⬇️
polyfill/runtest262.mjs 87.59% <0.00%> (+4.37%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@justingrant justingrant force-pushed the node-19-intl-repro branch 8 times, most recently from fa7665a to 7774bfe Compare December 16, 2022 13:08
@justingrant
Copy link
Collaborator Author

The reason why I wasn't seeing this on my local machine but was seeing it in CI turned out to be that GH Actions' Node 19 installs use ICU 72, while the versions available for download from nodejs's website and via homebrew use ICU 71. The root cause of the failures was this CLDR bug: https://unicode-org.atlassian.net/browse/CLDR-16243.

Closing in favor of the original PR #2448.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant