-
Notifications
You must be signed in to change notification settings - Fork 479
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
proposal-regexp-modifiers: Tests for syntax errors #3807
Conversation
Cases and templates to generate syntax error tests for regular expression modifiers, plus a few cases not worth templating.
Tests introduced by previous commits, generated from templates and cases by the usual scripts.
The main issue why this is still a draft, is that the templated test generator has some issues. /(?/*{ subpattern-add-modifiers }*/-/*{ subpattern-remove-modifiers }*/:a)//*{ global-modifiers }*/; But the generator cannot replace |
I created issue #3808 to report the problem. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good as far as invalid syntax coverage is concerned, at least once #3808 is resolved.
Based on PR tc39#3807 which had generated these tests from templates, but was stuck due to issue tc39#3808. Since these tests are a shipping blocker for v8, and tc39#3808 seems not straight-forward to fix, I modified the generated tests and removed the templates. One test is missing, as noted by @rbuckton in tc39#3960 (comment) to be added in a followup commit.
Based on PR tc39#3807 which had generated these tests from templates, but was stuck due to issue tc39#3808. Co-Authored-By: Guillaume Emont <[email protected]> Co-Authored-By: Ioanna M. Dimitriou H <[email protected]>
Based on PR tc39#3807 which had generated these tests from templates, but was stuck due to issue tc39#3808. Co-Authored-By: Guillaume Emont <[email protected]> Co-Authored-By: Ioanna M. Dimitriou H <[email protected]>
Closing in favour of #4016. |
Based on PR #3807 which had generated these tests from templates, but was stuck due to issue #3808. Co-Authored-By: Guillaume Emont <[email protected]> Co-Authored-By: Ioanna M. Dimitriou H <[email protected]>
This covers the syntax error cases from #3756.
This is an updated version of #3758 addressing review comments.