Add tests for no-tear requirement for integer typed arrays #4369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implementations may incorrectly call memcpy/memset (or similar functions) for fast copying of typed array contents. This can lead to teared reads or writes for integer typed arrays, which isn't allowed per spec.
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Jan 14, 2025
…key-reviewers,jandem
Reads/writes to integer typed arrays mustn't tear, so they can't be split into
single byte operations.
Replace single byte copy loops with `AtomicCopy{Down,Up}NoTearIfAlignedUnsynchronized`,
which performs additional checks when aligned word or dword copying is needed.
Test262 tests: <tc39/test262#4369>
Differential Revision: https://phabricator.services.mozilla.com/D233710
i3roly
pushed a commit
to i3roly/firefox-dynasty
that referenced
this pull request
Jan 14, 2025
…key-reviewers,jandem
Reads/writes to integer typed arrays mustn't tear, so they can't be split into
single byte operations.
Replace single byte copy loops with `AtomicCopy{Down,Up}NoTearIfAlignedUnsynchronized`,
which performs additional checks when aligned word or dword copying is needed.
Test262 tests: <tc39/test262#4369>
Differential Revision: https://phabricator.services.mozilla.com/D233710
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Jan 16, 2025
…key-reviewers,jandem
Reads/writes to integer typed arrays mustn't tear, so they can't be split into
single byte operations.
Replace single byte copy loops with `AtomicCopy{Down,Up}NoTearIfAlignedUnsynchronized`,
which performs additional checks when aligned word or dword copying is needed.
Test262 tests: <tc39/test262#4369>
Differential Revision: https://phabricator.services.mozilla.com/D233710
UltraBlame original commit: 968d34f043635337c9ab03c4c3f975c39e52f057
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Jan 16, 2025
…key-reviewers,jandem
Reads/writes to integer typed arrays mustn't tear, so they can't be split into
single byte operations.
Replace single byte copy loops with `AtomicCopy{Down,Up}NoTearIfAlignedUnsynchronized`,
which performs additional checks when aligned word or dword copying is needed.
Test262 tests: <tc39/test262#4369>
Differential Revision: https://phabricator.services.mozilla.com/D233710
UltraBlame original commit: 968d34f043635337c9ab03c4c3f975c39e52f057
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Jan 16, 2025
…key-reviewers,jandem
Reads/writes to integer typed arrays mustn't tear, so they can't be split into
single byte operations.
Replace single byte copy loops with `AtomicCopy{Down,Up}NoTearIfAlignedUnsynchronized`,
which performs additional checks when aligned word or dword copying is needed.
Test262 tests: <tc39/test262#4369>
Differential Revision: https://phabricator.services.mozilla.com/D233710
UltraBlame original commit: 968d34f043635337c9ab03c4c3f975c39e52f057
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementations may incorrectly call memcpy/memset (or similar functions) for fast copying of typed array contents. This can lead to teared reads or writes for integer typed arrays, which isn't allowed per spec.