Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid relative imports outside of test directory #4407

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Avoid relative imports outside of test directory #4407

wants to merge 1 commit into from
+21 −12

Conversation

linusg
Copy link
Member

@linusg linusg commented Feb 21, 2025

Closes #4406. Reverts to a state before #3980 at the cost of duplicating ensure-linking-error_FIXTURE.js (a one line source file).

@linusg linusg requested a review from a team as a code owner February 21, 2025 08:29
Ms2ger
Ms2ger approved these changes Feb 21, 2025
View reviewed changes
Copy link
Contributor

@Ms2ger Ms2ger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems sensible

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ms2ger Ms2ger Ms2ger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Import attributes tests violate module specifier rules
2 participants
@linusg @Ms2ger