Admin panel allow minors option #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
server: Add allowMinors in Settings schema. client: Add SettingsService updateAllowMinors function. server: Add '/settings/minors' api endpoint to update allowMinors setting. client: Add Additional Options section in admin settings.
|
Cool! Thanks for the PR :) |
jeremy-melnyk
force-pushed
the
allow_minors
branch
from
68249a0
to
1bf3568
Compare
Fix bug where scope.allowMinors was mixed scope.settings.allowMinors.
Modify 'checked' in adult form validation to user custom 'allowMinors' validation rule that uses the allowMinors flag from the current settings.
jeremy-melnyk
force-pushed
the
allow_minors
branch
from
1bf3568
to
b30b281
Compare
Changed the buttons to be toggle checkboxes. This is more intuitive than buttons, since 'allowMinors' reflects state, and not an action.
jeremy-melnyk
force-pushed
the
allow_minors
branch
from
b30b281
to
851e1c9
Compare
|
@ehzhang |
|
Deferring to @ehzhang to approve the UX changes, but otherwise lgtm 😄 thanks @Jeremy091 ! |
|
🎉 |
krubenok
pushed a commit
to hackmcgill/McHacks-Registration
that referenced
this pull request
Dec 21, 2017
Admin panel allow minors option
prabhanshuguptagit
pushed a commit
to prabhanshuguptagit/quill
that referenced
this pull request
Jan 23, 2019
Admin panel allow minors option
jtviolet
pushed a commit
to jtviolet/fountain
that referenced
this pull request
Aug 13, 2019
Admin panel allow minors option
jtviolet
pushed a commit
to jtviolet/fountain
that referenced
this pull request
Aug 13, 2019
Admin panel allow minors option
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #15
I saw this issue up for grabs, and I'd like to make a contribution for Hacktoberfest.
I created an 'Additional Options' sections on the admin settings page and added a 'Allow minors' checkbox.
Toggling this checkbox will update a new boolean property called
allowMinorsin the server's Settings schema, and update the settings client side. A 'put' endpoint was added to the server api.js to allow changes to theallowMinorssetting.The client's applicationCtrl.js now checks the the
allowMinorsflag in the settings when doing the form validation for the 'adult' property in the user's profile.I did my best to remain consistent with the codebase, and added as little as possible to get this working. Please don't hesitate to let me know if you'd like this done differently. Thanks!
Example Screenshots:
Additional options section.
Minors set to disallowed.
This is what it looks like when toggled to 'allowed'.
This is the confirmation that pops up after you toggle the checkbox.