Add phpstan check and fix level 0 issues.

tecnickcom · Oct 10, 2023 · 7997989 · 7997989
1 parent d4766d0
commit 7997989
Show file tree

Hide file tree

Showing 3 changed files with 28 additions and 5 deletions.
diff --git a/.github/workflows/check.yml b/.github/workflows/check.yml
@@ -60,3 +60,22 @@ jobs:
               with:
                 flags: php-${{ matrix.php-version }}-${{ matrix.os }}
                 name: php-${{ matrix.php-version }}-${{ matrix.os }}
+
+    static-analysis:
+        name: Static Analysis
+        runs-on: ubuntu-latest
+        steps:
+            - uses: actions/checkout@v4
+            - name: Use php 8.2
+              uses: shivammathur/setup-php@v2
+              with:
+                  php-version: 8.2
+            - name: Cache module
+              uses: actions/cache@v3
+              with:
+                  path: ~/.composer/cache/
+                  key: composer-cache
+            - name: Install phpstan
+              run: composer require --dev phpstan/phpstan
+            - name: Analyse files
+              run: ./vendor/bin/phpstan analyse src test
diff --git a/VERSION b/VERSION
@@ -1 +1 @@
-1.7.29
+1.7.31
diff --git a/test/TestUtil.php b/test/TestUtil.php
@@ -34,31 +34,35 @@ class TestUtil extends TestCase
     public function bcAssertEqualsWithDelta($expected, $actual, $delta = 0.01, $message = '')
     {
         if (\is_callable([self::class, 'assertEqualsWithDelta'])) {
-            return parent::assertEqualsWithDelta($expected, $actual, $delta, $message);
+            parent::assertEqualsWithDelta($expected, $actual, $delta, $message);
+            return;
         }
         return $this->assertEquals($expected, $actual, $message, $delta);
     }
 
     public function bcExpectException($exception)
     {
         if (\is_callable([self::class, 'expectException'])) {
-            return parent::expectException($exception);
+            parent::expectException($exception);
+            return;
         }
         return parent::setExpectedException($exception);
     }
 
     public function bcAssertIsResource($res)
     {
         if (\is_callable([self::class, 'assertIsResource'])) {
-            return parent::assertIsResource($res);
+            parent::assertIsResource($res);
+            return;
         }
         return parent::assertInternalType('resource', $res);
     }
 
     public function bcAssertMatchesRegularExpression($pattern, $string, $message = '')
     {
         if (\is_callable([self::class, 'assertMatchesRegularExpression'])) {
-            return parent::assertMatchesRegularExpression($pattern, $string, $message);
+            parent::assertMatchesRegularExpression($pattern, $string, $message);
+            return;
         }
         return parent::assertRegExp($pattern, $string, $message);
     }