Adopt ComboBox selectedItem prop #3749
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove previous workaround and adopt the `selectedItem` prop to
make the `ComboBox` component fully controlled.
To avoid the previous issue where the ComboBox would get into a loop
or cause the tests to crash due to OOM, we memoise the value passed
to `selectedItem` to ensure the same reference is kept if the value
is unchanged, e.g. in case of a selected namespace:
`{ id: namespace, text: namespace }`
we memoise on the `id` field so the same object is returned unless
the namespace changes. This avoid the ComboBox unnecessarily
re-rendering, and also handles the case of translated text for the
'All namespaces' option.
tekton-robot
added
kind/misc
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: briangleeson The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Follow-up to #3667 now that we've updated to
@carbon/[email protected]Remove previous workaround and adopt the
selectedItemprop to make theComboBoxcomponent fully controlled.To avoid the previous issue where the ComboBox would get into a loop or cause the tests to crash due to OOM, we memoise the value passed to
selectedItemto ensure the same reference is kept if the value is unchanged, e.g. in case of a selected namespace:{ id: namespace, text: namespace }we memoise on the
idfield so the same object is returned unless the namespace changes. This avoid the ComboBox unnecessarily re-rendering, and also handles the case of translated text for the 'All namespaces' option./kind misc
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
functionality, content, code)
/kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes