Skip to content

Commit

Permalink
chore: demote HelpWanted
Browse files Browse the repository at this point in the history
I no longer use HelpWanted except very briefly when I am parsing the
command line arguments.

Remove HelpWwanted from the app itself and make it a short-lived
variable instead.
  • Loading branch information
telemachus committed Nov 26, 2024
1 parent d6ffc0c commit 5c47304
Showing 1 changed file with 6 additions and 6 deletions.
12 changes: 6 additions & 6 deletions internal/cli/app.go
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@ type App struct {
CmdName string
Usage string
ExitValue int
HelpWanted bool
QuietWanted bool
}

Expand Down Expand Up @@ -61,12 +60,13 @@ func (app *App) Flags(args []string) (string, bool) {
}
cmdFlags := flag.NewFlagSet("gitmirror", flag.ContinueOnError)
cmdFlags.SetOutput(io.Discard)
var configFile string
var configIsDefault bool
cmdFlags.BoolVar(&app.HelpWanted, "help", false, "")
cmdFlags.BoolVar(&app.HelpWanted, "h", false, "")
var helpWanted bool
cmdFlags.BoolVar(&helpWanted, "help", false, "")
cmdFlags.BoolVar(&helpWanted, "h", false, "")
cmdFlags.BoolVar(&app.QuietWanted, "quiet", false, "")
cmdFlags.BoolVar(&app.QuietWanted, "q", false, "")
var configFile string
var configIsDefault bool
cmdFlags.StringVar(&configFile, "config", "", "")
cmdFlags.StringVar(&configFile, "c", "", "")
err := cmdFlags.Parse(args)
Expand All @@ -75,7 +75,7 @@ func (app *App) Flags(args []string) (string, bool) {
case err != nil:
fmt.Fprintf(os.Stderr, "%s: %s\n%s", app.CmdName, err, app.Usage)
app.ExitValue = exitFailure
case app.HelpWanted:
case helpWanted:
fmt.Fprintf(os.Stderr, "%s: use 'help' not '-help' or '-h'\n", app.CmdName)
fmt.Fprint(os.Stderr, app.Usage)
app.ExitValue = exitFailure
Expand Down

0 comments on commit 5c47304

Please sign in to comment.