Skip to content

Commit

Permalink
chore(revive): use a stricter revive config
Browse files Browse the repository at this point in the history
(But also ignore optionparser for now.)
  • Loading branch information
telemachus committed Dec 9, 2024
1 parent 6c81d37 commit 7fb79b6
Show file tree
Hide file tree
Showing 2 changed files with 19 additions and 26 deletions.
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ staticcheck: fmt
staticcheck ./...

revive: fmt
revive -config revive.toml ./...
revive -config revive.toml -exclude internal/optionparser ./...

test:
go test -shuffle on github.com/telemachus/gitmirror/internal/cli
Expand Down
43 changes: 18 additions & 25 deletions revive.toml
Original file line number Diff line number Diff line change
@@ -1,30 +1,23 @@
ignoreGeneratedHeader = false
severity = "warning"
confidence = 0.8
errorCode = 0
errorCode = 1
warningCode = 0

[rule.blank-imports]
[rule.context-as-argument]
[rule.context-keys-type]
[rule.dot-imports]
[rule.error-return]
[rule.error-strings]
[rule.error-naming]
[rule.exported]
[rule.if-return]
[rule.increment-decrement]
[rule.var-naming]
[rule.var-declaration]
[rule.package-comments]
[rule.range]
[rule.receiver-naming]
[rule.time-naming]
[rule.unexported-return]
[rule.indent-error-flow]
[rule.errorf]
[rule.empty-block]
[rule.superfluous-else]
[rule.unused-parameter]
[rule.unreachable-code]
[rule.redefines-builtin-id]
enableAllRules = true

[rule.add-constant]
Disabled = true

[rule.deep-exit]
Disabled = true

[rule.flag-parameter]
Disabled = true

[rule.line-length-limit]
Arguments = [100]

[rule.unhandled-error]
Arguments = ["fmt.Printf", "fmt.Fprintf", "fmt.Println", "fmt.Fprintln"]

0 comments on commit 7fb79b6

Please sign in to comment.