feat: add support for saving public key to file using -output flag #318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmd/tesla-keygen/main.go
Outdated
| @@ -90,7 +104,9 @@ func main() { | |||
| config.RegisterCommandLineFlags() | |||
| flag.Usage = cliUsage | |||
| flag.BoolVar(&overwrite, "f", false, "Overwrite existing key if it exists") | |||
| flag.StringVar(&outputFile, "output", "", "Path to save the public key") | |||
There was a problem hiding this comment.
The output of tesla-keygen --help becomes:
-keyring-type type
Keyring type (file|keychain|pass). Defaults to $TESLA_KEYRING_TYPE.
-output string
Path to save the public key
-session-cache file
Load session info cache from file. Defaults to $TESLA_CACHE_FILE.
To make the argument of -outupt "file" rather than "string", which is more consistent with the other options, please change the help string to:
Save public key to `file`. Defaults to stdout.
There was a problem hiding this comment.
Suggestion applied
|
|
||
| // If outputFile is provided, write to file, else write to stdout | ||
| var out io.Writer = os.Stdout | ||
| if outputFile != "" { |
There was a problem hiding this comment.
Currently usageText says:
The program writes the public key to stdout (except when deleting a key)
Please change to
The program writes the public key to stdout (except when deleting a key or setting the output location with -output)
There was a problem hiding this comment.
Suggestion applied
- Introduced the `-output` flag to allow users to specify a file path for saving the public key. - Updated the `printPublicKey` function to write the public key to the specified file, or to stdout if no file is provided. - Modified the `create` and `migrate` cases to support the `-output` flag when printing the public key. - Ensured backward compatibility by retaining stdout output when `-output` is not used.
pmpbaptista
force-pushed
the
pb/keygen-output
branch
from
3896bb1 to
b3a206f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
-outputflag to allow users to specify a file path for saving the public key.printPublicKeyfunction to write the public key to the specified file, or to stdout if no file is provided.createandmigratecases to support the-outputflag when printing the public key.-outputis not used.Fixes # (issue)
Type of change
Please select all options that apply to this change:
Checklist:
Confirm you have completed the following steps: