feat: add mailpit as module #1134
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for testcontainers-dotnet ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
HofmeisterAn
added
enhancement
|
Sorry for the late response. I will try to review the PR next week ✌️. |
|
Relates to #1153. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds
Testcontainers.Mailpitas a module to the project.Why is it important?
Mailpit is an extremely useful tool for testing email related features and I think having it as a module to use inside the Testcontainers .NET C# ecosystem is worth the effort.
Related issues
Didn't find any.
How to test this PR
I've added simple a test that ensures the SMTP and Web servers are working accordingly by sending the email and querying the REST api for that specific email.
To run this test in your shell:
Follow-ups
If this PR is acceptable, I think there is still some tidying-up of the
.slnfiles to keep consistency as I've seen done in other merged PRs.