-
-
Notifications
You must be signed in to change notification settings - Fork 277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add Aspire Dashboard module #1190 #1194
base: develop
Are you sure you want to change the base?
feat: Add Aspire Dashboard module #1190 #1194
Conversation
✅ Deploy Preview for testcontainers-dotnet ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your PR. Overall, it looks good and aligns well with our module approach. Thank you for following the repository standards. However, there are a few things we need to address before we can merge the PR. Nothing major. If you have any further questions, need help, or would like to discuss any topics, I am happy to help.
src/Testcontainers.AspireDashboard/AspireDashboardConfiguration.cs
Outdated
Show resolved
Hide resolved
Sorry, long time no see. I plan to continue working on this one |
@HofmeisterAn please take a look. Thank you |
What does this PR do?
Adds Aspire Dashboard support.
Why is it important?
As discussed in #1190, it would be great to have this Testcontainer.