Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Aspire Dashboard module #1190 #1194

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from

Conversation

NikiforovAll
Copy link

What does this PR do?

Adds Aspire Dashboard support.

Why is it important?

As discussed in #1190, it would be great to have this Testcontainer.

Copy link

netlify bot commented Jun 11, 2024

Deploy Preview for testcontainers-dotnet ready!

Name Link
🔨 Latest commit 4bd053b
🔍 Latest deploy log https://app.netlify.com/sites/testcontainers-dotnet/deploys/66eeaea6813eb9000847ba7d
😎 Deploy Preview https://deploy-preview-1194--testcontainers-dotnet.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@HofmeisterAn HofmeisterAn added enhancement New feature or request module An official Testcontainers module labels Jun 13, 2024
Copy link
Collaborator

@HofmeisterAn HofmeisterAn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR. Overall, it looks good and aligns well with our module approach. Thank you for following the repository standards. However, there are a few things we need to address before we can merge the PR. Nothing major. If you have any further questions, need help, or would like to discuss any topics, I am happy to help.

@NikiforovAll
Copy link
Author

Sorry, long time no see. I plan to continue working on this one

@NikiforovAll
Copy link
Author

Thanks for your PR. Overall, it looks good and aligns well with our module approach. Thank you for following the repository standards. However, there are a few things we need to address before we can merge the PR. Nothing major. If you have any further questions, need help, or would like to discuss any topics, I am happy to help.

@HofmeisterAn please take a look. Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request module An official Testcontainers module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants