Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(#200): add k3s pod api example #202

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

bbortt
Copy link

@bbortt bbortt commented Aug 31, 2024

reproducer for #200.. let's see if I am the honk 😜

@bbortt
Copy link
Author

bbortt commented Sep 3, 2024

whoever approved the workflow beforehand; thanks. can you please do it again?

I was unable to build this community modules project locally up until now, but managed to do so now. for anyone running into problems with rdkafka on windows ("this is not an x32 architecture"), try adding the cmake build:

rdkafka = { version = "0.36", features = ["cmake-build"] }

cc: @DDtKey

Copy link
Contributor

@DDtKey DDtKey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution and example! 🙏

whoever approved the workflow beforehand; thanks. can you please do it again?

Done ✅

src/k3s/mod.rs Outdated Show resolved Hide resolved
@bbortt
Copy link
Author

bbortt commented Sep 3, 2024

@DDtKey here come some more findings..

I did only manage to run multiple tests using k3s in serial, not parallel mode. I therefore had to add the test_serial create to the dev-dependencies.

if you don't do that and run the tests in parallel you'll run into the exact same error that happened in the last "test (stable)" job. it's quit reproducible! I think in around 10 times I ran it locally it never passed.

on the other hand, the error initially reported in #200 did no longer occur. that's good 😉 however, that also means I have to double-check the code in my other project - that's less good haha

finally, I've used the busybox image for the test. I think it's less "random" and quit known. it's also only around 1.5 MB in size, so sufficiently small to not really slow down the ci imo. what do you think of it?

and finally, thanks for all your patience! it's my first rust project contribution ❤️ I've already learned a lot again.

edit: one addition; maybe the documentation should be completed with the hint that there seem to be problems with running tests using k3s in parallel? I could add that.

example using the k8s pod api. also showcases running multiple k3s
tests is only possible in serial (see `serial_test` crate).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants