Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not install tests #15

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

scop
Copy link
Contributor

@scop scop commented Oct 24, 2020

@jelmer
Copy link
Member

jelmer commented Sep 1, 2023

While I have sympathy for the argument of not installing tests for disk usage reasons in general, the other arguments listed on that page don't make sense to me:

  • there may be no single standard way of running tests; there is no single standard way of invoking other python code once installed either. And while there is no single standard, there are various standards for specifying tests, such as test_suite in setup.cfg, a directory name tests, simply doing test discovery with pytest
  • dependencies can be specified with tests_require in setup.cfg, or could e.g. be specified with a "tests" extra
  • it's obviously a bad idea to install test code that is not ready for that, but that's just an argument for fixing that or only installing test code that is safe to run

The fact that it's not necessarily easy to run tests out of the box could just be an argument for making it easier.

In this particular case, we're talking about 16k; is that really worth it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants