-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: add simple typing tests #298
Conversation
First victim of the test matrix. :-) The types don't agree with Svelte 3. We probably have to skip them for that version. |
I was really hoping I could come up with a clever fix for this, but no such luck. I'll disable in the matrix as suggested. I wonder what this looks like in an actual Svelte 3 + TS project? Might have to spin one up and check it out; probably worth noting in the docs while I'm in there |
Spun up a little Svelte 3 + TS project, and I'm not 100% sure how, but the types definitely work correctly. Probably some magic from Interestingly enough, while testing I discovered that the latest version of |
I reckon that we'll eventually have to either drop support for Svelte 3, or create a maintenance branch for it. Which makes me think that I have to see if the semantic release mechanism even allows for different maintenance branches. 🤔 |
# Conflicts: # .github/workflows/release.yml # package.json
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nothing to see here...
🎉 This PR is included in version 4.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Overview
This PR adds simple typing tests. Since Vitest's type-testing doesn't support Svelte (only vanilla TS and Vue), I implemented tests using expect-type - the library Vitest uses under the hood - and svelte-check.
Closes #199, related to #194, #195
Change log