Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactored project to Typescript #24

Merged
merged 4 commits into from
Aug 25, 2024
Merged

Refactored project to Typescript #24

merged 4 commits into from
Aug 25, 2024

Conversation

tannaurus
Copy link
Collaborator

Description

It's come up here and there, so I figured I'd put this together to see how the team wants to proceed here. We can also totally close this if we feel it's just unnecessary complexity 🙏

This PR:

  • Converts the codebase to TypeScript
  • Adds io-ts to deserialize the firebase responses

Workflow changes

Because we're using vite, who boasts itself on "not doing type checking" in an effort to increase build times, you either have to rely on your ide's language server or tsc directly. What works really well for me is running tsc --noEmit --watch inside a terminal that I can keep my eye on while working.

Copy link

github-actions bot commented Aug 25, 2024

Visit the preview URL for this PR (updated for commit 42eb376):

https://tcl-77-smart-shopping-list--pr24-tg-typescript-lwiggz45.web.app

(expires Sun, 01 Sep 2024 23:20:40 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: b77df24030dca7d8b6561cb24957d2273c5e9d72

@tannaurus tannaurus merged commit 6c259bf into main Aug 25, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant