Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It's come up here and there, so I figured I'd put this together to see how the team wants to proceed here. We can also totally close this if we feel it's just unnecessary complexity 🙏
This PR:
Workflow changes
Because we're using vite, who boasts itself on "not doing type checking" in an effort to increase build times, you either have to rely on your ide's language server or
tsc
directly. What works really well for me is runningtsc --noEmit --watch
inside a terminal that I can keep my eye on while working.