Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue # 10 Prevent user from adding duplicate or empty item to the list #34

Merged
merged 10 commits into from
Sep 15, 2024
Merged

Issue # 10 Prevent user from adding duplicate or empty item to the list #34

merged 10 commits into from
Sep 15, 2024

Commits on Sep 11, 2024

  1. refactored validateTrimmedString to normalize punctuation errors and … 

    …added a toast error to notify user of empty item name
    @eternalmaha
    eternalmaha committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    9a55469 View commit details
    Browse the repository at this point in the history

  2. refactored toast notifcations to correctly display item names validat… 

    …ed for emptiness or punctuaction marks
    @eternalmaha
    eternalmaha committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    7995534 View commit details
    Browse the repository at this point in the history

Commits on Sep 12, 2024

  1. refactored validateItemString to check for duplicate item names enter… 

    …ed and add only original names to shopping list
    @eternalmaha
    eternalmaha committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    b321236 View commit details
    Browse the repository at this point in the history

  2. Change validation function to return specific errors. Change handleSu… 

    …bmit function to return early if validationError is detected
    @zahrafalak
    zahrafalak committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    eb21d28 View commit details
    Browse the repository at this point in the history

Commits on Sep 13, 2024

  1. Fix the handleSubmit function to return early if validation error caught

    @zahrafalak
    zahrafalak committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    c92e31e View commit details
    Browse the repository at this point in the history

  2. Change some variable names to more descriptive ones

    @zahrafalak
    zahrafalak committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    8ece059 View commit details
    Browse the repository at this point in the history

  3. updated toast notifications with descriptives for duplicate item names

    @eternalmaha
    eternalmaha committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    a1deb44 View commit details
    Browse the repository at this point in the history

  4. change punctuation regex to also check for spaces in the duplicate input

    @zahrafalak
    zahrafalak committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    ff10339 View commit details
    Browse the repository at this point in the history

Commits on Sep 15, 2024

  1. refactor normalizedInputName to accept digits

    @eternalmaha
    eternalmaha committed Sep 15, 2024
    Configuration menu
    Copy the full SHA
    654a733 View commit details
    Browse the repository at this point in the history

  2. reverse refactor of normalizedInputName to allow digit

    @eternalmaha
    eternalmaha committed Sep 15, 2024
    Configuration menu
    Copy the full SHA
    f823aeb View commit details
    Browse the repository at this point in the history