Add CreateShoppingList file to components folder #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
User able to submit shopping list name which will then show in firebase database and also render on our home page
|
Visit the preview URL for this PR (updated for commit f6c3934): https://tcl-79-smart-shopping-list--pr21-jo-hm-createlist-hq5pgndh.web.app (expires Sat, 31 Aug 2024 10:38:41 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: d91d9ddbda780208241c52942f544acf8e81407a |
joriordan332
changed the title
marshjaja
approved these changes
Aug 23, 2024
redapy
approved these changes
Aug 23, 2024
| @@ -17,6 +19,7 @@ export function Home({ data, setListPath }) { | |||
| /> | |||
| ))} | |||
| </ul> | |||
| <CreateShoppingList user={user} setListPath={setListPath} /> | |||
There was a problem hiding this comment.
I love that you created a separate component for the form! It really helps with reusability and keeps the code better organized.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a CreateShoppingList component that allows the user to create new shopping lists.
Related Issue
Closes #4
Acceptance Criteria
UI-related tasks:
☑️ The Home view displays a form that allows users to enter the name of a shopping list and then create a list with that name.
☑️ The input that accepts the name of the item has a semantic label element associated with it
☑️ The user can submit this form with both the mouse and the Enter key
☑️ When the user submits the form, they see a message indicating that the list either was or was not created and saved to the database.
Data-related tasks:
☑️ Clicking the button uses the createList function in src/api/firebase.js to create a new shopping list for the user.
☑️ The shopping list path is stored in local storage using the setListPath function.
☑️ Once the list has been created and saved, the user is redirected to the List view.
Type of Changes
feature
Updates
Before
After
Testing Steps / QA Criteria
Do a
git pullandgit checkout jo-hm-createListOpen the homepage by running
npm start.Enter a shopping list name into the input box.
Either click 'Create Shopping List' or press the enter key.
App will then automatically navigate to 'List' if the shopping list has been added successfully and a notification will appear telling the user this.
If their has been an error adding the shopping list an error notification will appear asking the user to try again.