Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't cache error data #310

Merged
merged 2 commits into from
Sep 11, 2024
Merged

Don't cache error data #310

merged 2 commits into from
Sep 11, 2024

Conversation

Razzmatazzz
Copy link
Member

Currently, when the bot updates data it replaces the cached data with whatever the response is. With this PR, it will not replace cached data if the response has an error.

@Razzmatazzz Razzmatazzz requested a review from a team as a code owner September 10, 2024 11:29
Copy link
Contributor

👋 Thanks for opening a pull request!

If you are new, please check out the deployment process below to understand how to deploy this pull request:

  1. 👀 Observe the CI output on this pull request to ensure it is passing and doing what it is supposed to do

  2. ✔️ Obtain an approval/review on this pull request

  3. 🚀 Branch deploy your pull request to production with .deploy

    Comment .deploy on this pull request to trigger a deploy. If anything goes wrong, rollback with .deploy main

  4. 🎉 Merge!

If you need additional help with branch deployments, checkout the usage guide

@Razzmatazzz
Copy link
Member Author

.deploy

Copy link
Contributor

Deployment Triggered 🚀

Razzmatazzz, started a branch deployment to production

You can watch the progress here 🔗

Branch: no-cache-error-data

Copy link
Contributor

Deployment Results ✅

Razzmatazzz successfully deployed branch no-cache-error-data to production

@Razzmatazzz Razzmatazzz merged commit 1aeb56f into main Sep 11, 2024
2 checks passed
@Razzmatazzz Razzmatazzz deleted the no-cache-error-data branch September 11, 2024 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants