Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added 2 options to Visual regression reporter #17

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

GARMBoshouwers
Copy link

  • onlyReportErrors: Only display visual regressions in the report. Default option is false, so all tested screenshots are added to the report, which was the original system. When set to true, only reports that did not pass are added to the report, which makes it easier to find regressions by testers.
  • prefixTestName: Prefix the test name in the report with the parent test suite names. Default option is false, so the Comparison Header is the same as the original system. When set to true, the Comparison header is prefixed with the parent suite names to distinguish them in multi-suite runs.

- onlyReportErrors: Only display visual regressions in the report
- prefixTestName: Prefix the test name in the report with the parent test suite names
@jsf-clabot
Copy link

jsf-clabot commented Oct 11, 2019

CLA assistant check
All committers have signed the CLA.

@GARMBoshouwers
Copy link
Author

Is there something more I have to do for that CLA? I clicked on the details of that check and agreed there as far as I can see, but it is still pending.

@jason0x43
Copy link
Member

Hmmm... there shouldn't be. I'll look into it.

@jason0x43
Copy link
Member

If you click the Details link now, does it tell you that you have signed the CLA?

@GARMBoshouwers
Copy link
Author

First I get the form where I need to sign in with my GitHub credentials. If I do that, it says "You have signed the CLA for theintern/visual-plugin", so I assumed it should be correct.

@GARMBoshouwers
Copy link
Author

Hmm, I did sign that agreement with my personal email, but I made the commit with my work account. These two adresses are both connected to my GitHub account. Could that be a problem?

@jason0x43
Copy link
Member

It's possible. Try updating the commit with your personal email and force-push.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants