Show all the people related with a state in the place page #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
octopusinvitro
force-pushed
the
people-in-state-page
branch
14 times, most recently
from
ca5d89b to
88626e2
Compare
octopusinvitro
force-pushed
the
people-in-state-page
branch
3 times, most recently
from
257f13d to
3679ef1
Compare
octopusinvitro
force-pushed
the
people-in-state-page
branch
3 times, most recently
from
bde8c38 to
fa24cc9
Compare
octopusinvitro
force-pushed
the
people-in-state-page
branch
2 times, most recently
from
91e1efd to
ede6920
Compare
octopusinvitro
force-pushed
the
people-in-state-page
branch
from
ede6920 to
22f0c99
Compare
Rewritten to make it work as the same method in MembershipCSV people
Use safe navigation operator (&.) for checks (available from Ruby 2.3 on)
instead of the longer:
people_by_legislature.current_term_start_date.year
if people_by_legislature.current_term_start_date
The parent place pages don't show a current term start date. The
information related with the legislature is taken from the people.
Since parent places receive an instance of people that returns nil
for the legislature related methods (legislature name and current
term start date) we have to do this check before we ask it for the
year.
octopusinvitro
force-pushed
the
people-in-state-page
branch
from
22f0c99 to
449509e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP