Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaking changes in v2.0 #230

Open
1 task done
lqt93 opened this issue Jun 19, 2021 · 7 comments
Open
1 task done

Breaking changes in v2.0 #230

lqt93 opened this issue Jun 19, 2021 · 7 comments
Labels
discussion Need to discuss before implementation

Comments

@lqt93
Copy link
Contributor

lqt93 commented Jun 19, 2021

This issue lists changes for @moai/[email protected] Proposed ones are unchecked boxes and confirmed ones are checked.

  • MenuItem: Change name of 'fn' prop to 'onClick'
@lqt93 lqt93 added the discussion Need to discuss before implementation label Jun 26, 2021
@thien-do thien-do pinned this issue Jun 28, 2021
@thien-do thien-do changed the title Things for v2.0 Breaking changes in v2.0 Jun 28, 2021
@monodyle
Copy link
Contributor

Should rename styling name, like in Pane:

https://github.com/moaijs/moai/blob/8332c2795b36e6f2f32474337415a6843eaf4eff/lib/core/src/pane/pane.tsx#L46

Can't understand what the hell is outset

@thien-do
Copy link
Owner

We will also need to deprecate the "href" prop in Button in favor of the Anchor component.

@thien-do
Copy link
Owner

thien-do commented Jul 3, 2021

Under consideration: Remove the convenient support of Input.list as an array. Maybe only support it as a string (the user must provide the list themselves)

@monodyle
Copy link
Contributor

Should change name of Swither

@thien-do
Copy link
Owner

Should use headlessui https://github.com/tailwindlabs/headlessui/issues

@thien-do
Copy link
Owner

Don't reset globally, reset in component. Only normalize globally

@rovn208
Copy link
Contributor

rovn208 commented Nov 21, 2021

Do not use noreferrer as a default tag for Link Button's rel attribute

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion Need to discuss before implementation
Projects
None yet
Development

No branches or pull requests

4 participants