Chore(button): Button should pass onClick to its "a" render and suppo… #291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/makeinvietnam/moai-docs/67Tw8SEANmaGxYjJ3rbHmkzMuJjW |
rovn208
force-pushed
the
chore/button-attributes
branch
from
092fed2
to
94be34b
Compare
thien-do
approved these changes
Nov 20, 2021
| download={props.download} | ||
| rel="noopener noreferrer" | ||
| target={props.target} | ||
| rel={props.rel || "noopener noreferrer"} |
There was a problem hiding this comment.
hm we should not default to "noopener..." anyway :( but removing that would break version... so please add this note to #230
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGES