Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Drum app using js #587

Merged
merged 1 commit into from
Oct 2, 2023
Merged

Added Drum app using js #587

merged 1 commit into from
Oct 2, 2023

Conversation

falgun143
Copy link
Contributor

@falgun143 falgun143 mentioned this pull request Oct 2, 2023
Open
@falgun143
Copy link
Contributor Author

on key board when valid letters are pressed then corresponding sound is heard.That is what happens at the end of the video.

@thinkswell thinkswell merged commit d986f0e into thinkswell:master Oct 2, 2023
@falgun143
Copy link
Contributor Author

@thinkswell please tell me what to do this pr is not able to pass all the checks of the github
image
This is the yml file in workflow
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@falgun143 @thinkswell