Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TOOL-3328] Dashboard: Show error message in toast on Email submission fail in onboaridng flow #6186

Merged
merged 1 commit into from
Feb 7, 2025

Conversation

MananTank
Copy link
Member

@MananTank MananTank commented Feb 6, 2025

PR-Codex overview

This PR focuses on enhancing error handling in the AccountForm component by improving error messages and integrating toast notifications for better user feedback.

Detailed summary

  • Added toast import from sonner.
  • Changed the onError function parameter from err to error.
  • Added console logging for errors.
  • Implemented specific toast notifications for duplicate email and invalid email address errors.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

linear bot commented Feb 6, 2025

Copy link

vercel bot commented Feb 6, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 7, 2025 8:47pm
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Feb 7, 2025 8:47pm
login ⬜️ Skipped (Inspect) Feb 7, 2025 8:47pm
thirdweb_playground ⬜️ Skipped (Inspect) Feb 7, 2025 8:47pm
wallet-ui ⬜️ Skipped (Inspect) Feb 7, 2025 8:47pm

@vercel vercel bot temporarily deployed to Preview – docs-v2 February 6, 2025 22:27 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground February 6, 2025 22:27 Inactive
@vercel vercel bot temporarily deployed to Preview – login February 6, 2025 22:27 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui February 6, 2025 22:27 Inactive
Copy link

changeset-bot bot commented Feb 6, 2025

⚠️ No Changeset found

Latest commit: 41d5044

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Feb 6, 2025
Copy link
Member Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@MananTank MananTank marked this pull request as ready for review February 6, 2025 22:27
@MananTank MananTank requested review from a team as code owners February 6, 2025 22:27
Copy link

codecov bot commented Feb 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.76%. Comparing base (a8ac98b) to head (41d5044).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6186   +/-   ##
=======================================
  Coverage   56.76%   56.76%           
=======================================
  Files        1161     1161           
  Lines       64261    64261           
  Branches     5197     5197           
=======================================
  Hits        36479    36479           
  Misses      27053    27053           
  Partials      729      729           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from a8ac98b
packages 54.94% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

Copy link
Contributor

github-actions bot commented Feb 6, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 46.21 KB (0%) 925 ms (0%) 2.4 s (-28.47% 🔽) 3.4 s
thirdweb (cjs) 121.82 KB (0%) 2.5 s (0%) 6.2 s (-21.5% 🔽) 8.6 s
thirdweb (minimal + tree-shaking) 5.6 KB (0%) 112 ms (0%) 409 ms (+26.92% 🔺) 521 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 260 ms (+267.57% 🔺) 270 ms
thirdweb/react (minimal + tree-shaking) 19.3 KB (0%) 386 ms (0%) 584 ms (-26.82% 🔽) 970 ms

Copy link

graphite-app bot commented Feb 7, 2025

Merge activity

graphite-app bot pushed a commit that referenced this pull request Feb 7, 2025
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground February 7, 2025 12:22 Inactive
@vercel vercel bot temporarily deployed to Preview – login February 7, 2025 12:22 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 February 7, 2025 12:22 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui February 7, 2025 12:22 Inactive
…n fail in onboaridng flow (#6186)

<!-- start pr-codex -->

## PR-Codex overview
This PR enhances error handling in the `AccountForm` component by improving the way errors are processed and displayed to the user.

### Detailed summary
- Replaced the `onError` parameter's type from `Error` to a more generic `error`.
- Added console logging for errors.
- Implemented specific error handling for duplicate email and invalid email address cases.
- Integrated `toast` notifications for user-friendly error messages.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@vercel vercel bot temporarily deployed to Preview – docs-v2 February 7, 2025 20:40 Inactive
@vercel vercel bot temporarily deployed to Preview – login February 7, 2025 20:40 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui February 7, 2025 20:40 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground February 7, 2025 20:40 Inactive
@graphite-app graphite-app bot merged commit 41d5044 into main Feb 7, 2025
33 checks passed
@graphite-app graphite-app bot deleted the TOOL-3328 branch February 7, 2025 20:48
@vercel vercel bot temporarily deployed to Production – login February 7, 2025 20:48 Inactive
@vercel vercel bot temporarily deployed to Production – docs-v2 February 7, 2025 20:48 Inactive
@vercel vercel bot temporarily deployed to Production – thirdweb_playground February 7, 2025 20:48 Inactive
@vercel vercel bot temporarily deployed to Production – wallet-ui February 7, 2025 20:48 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dashboard Involves changes to the Dashboard.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants