-
Notifications
You must be signed in to change notification settings - Fork 446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TOOL-3328] Dashboard: Show error message in toast on Email submission fail in onboaridng flow #6186
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6186 +/- ##
=======================================
Coverage 56.76% 56.76%
=======================================
Files 1161 1161
Lines 64261 64261
Branches 5197 5197
=======================================
Hits 36479 36479
Misses 27053 27053
Partials 729 729
*This pull request uses carry forward flags. Click here to find out more. |
size-limit report 📦
|
Merge activity
|
…n fail in onboaridng flow (#6186)
4921a66
to
2e54f78
Compare
…n fail in onboaridng flow (#6186) <!-- start pr-codex --> ## PR-Codex overview This PR enhances error handling in the `AccountForm` component by improving the way errors are processed and displayed to the user. ### Detailed summary - Replaced the `onError` parameter's type from `Error` to a more generic `error`. - Added console logging for errors. - Implemented specific error handling for duplicate email and invalid email address cases. - Integrated `toast` notifications for user-friendly error messages. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex -->
2e54f78
to
41d5044
Compare
PR-Codex overview
This PR focuses on enhancing error handling in the
AccountForm
component by improving error messages and integrating toast notifications for better user feedback.Detailed summary
toast
import fromsonner
.onError
function parameter fromerr
toerror
.