update ovmf + armvirt display configuration for setup #10631
+50
−47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This way we have the display configuration in a single place and need to change one file only to update all build variants. Signed-off-by: Gerd Hoffmann <[email protected]>
Signed-off-by: Gerd Hoffmann <[email protected]>
Signed-off-by: Gerd Hoffmann <[email protected]>
Signed-off-by: Gerd Hoffmann <[email protected]>
Set both PcdVideo*Resolution and PcdSetupVideo*Resolution PCDs. This avoids pointless video mode changes when entering and leaving the firmware setup application. Signed-off-by: Gerd Hoffmann <[email protected]>
Set both PcdVideo*Resolution and PcdSetupVideo*Resolution PCDs. This avoids pointless video mode changes when entering and leaving the firmware setup application. Signed-off-by: Gerd Hoffmann <[email protected]>
Set both PcdVideo*Resolution and PcdSetupVideo*Resolution PCDs. This avoids pointless video mode changes when entering and leaving the firmware setup application. Signed-off-by: Gerd Hoffmann <[email protected]>
Set both PcdVideo*Resolution and PcdSetupVideo*Resolution PCDs. This avoids pointless video mode changes when entering and leaving the firmware setup application. Signed-off-by: Gerd Hoffmann <[email protected]>
Setting PcdSetupConOut* to zero turns on autodetection mode for rows and cols, so the firmware setup application will use the use complete available screen space. Signed-off-by: Gerd Hoffmann <[email protected]>
Signed-off-by: Gerd Hoffmann <[email protected]>
kraxel
force-pushed
the
devel/setup-display
branch
from
bda33a2 to
64b3fc7
Compare
kraxel
changed the title
tianocore-assign-reviewers
bot
requested review from
andreiw,
ardbiesheuvel,
jyao1,
leiflindholm,
samimujawar,
tperard and
vlsunil
ardbiesheuvel
approved these changes
Jan 16, 2025
vlsunil
approved these changes
Jan 16, 2025
|
Can you squash the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch series makes sure the video PCDs for normal mode and for setup mode are identical. This gets rid of pointless video mode changes when entering/leaving the firmware setup application.
The patch series also moves all the PCDs to an include file to reduce duplication.