Compatibility Fixes #53
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While trying to setup some integrated performance tests, I ran into issues with platform-client calls not actually working (or doing what I expected). These are some fixes that allow the client to operate. All changes should be additions, i.e. old behavior shouldn't change.
|
Cool - I will take a better look tomorrow @cheddar |
|
Since you just popped up elsewhere, @cheddar are the changes here still things you'd like addressed? I was looking at this PR earlier today (as I'm thinking about the future of platform-client generally) and wondering if you were still waiting on it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While trying to setup some integrated performance tests, I ran into
issues with platform-client calls not actually working (or doing
what I expected). These are some fixes that allow the client to operate.
All changes should be additions, i.e. old behavior shouldn't change.