[BACK-2989] Add Twiist provider #724
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toddkazakov
force-pushed
the
tk/add-twiist
branch
from
86451e9
to
c303a00
Compare
ewollesen
reviewed
Jun 13, 2024
| @@ -51,6 +51,11 @@ func NewProvider(name string, configReporter config.Reporter) (*Provider, error) | |||
| } | |||
| cfg.Scopes = SplitScopes(configReporter.GetWithDefault("scopes", "")) | |||
|
|
|||
| authStyleInParams := configReporter.GetWithDefault("auth_style_in_params", "") | |||
| if authStyleInParams == "true" { | |||
There was a problem hiding this comment.
strconv.ParseBool might have been a good fit here.
| AccessToken: t.AccessToken, | ||
| TokenType: t.TokenType, | ||
| RefreshToken: t.RefreshToken, | ||
| Expiry: t.ExpirationTime, | ||
| } | ||
| if t.IdToken != "" { | ||
| token.WithExtra(map[string]any{ |
|
@ewollesen unfortunately, the newly added code is rather difficult to test in isolation - it requires a whole lot of mocking in order to test that a task is created on linking and the task is deleted when accounts are unlinked. Same holds true for the pre-existing Dexcom code which also lacks such tests. Given that there isn't much going on here, I think it's ok this to be tested manually by the QA team. |
ewollesen
approved these changes
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.