Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add evaluation of not looping alerts #751

Draft
wants to merge 15 commits into
base: eric-cpa-alerts
Choose a base branch
from

Commits on Jul 11, 2024

  1. adds List and Get methods to alerts client

    The Get endpoint already exists on the service, so only the List endpoint
    needed to be added there.
    
    BACK-2554
    ewollesen committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    4515bd5 View commit details
    Browse the repository at this point in the history
  2. lift Repeat out of the base alert config

    Through discussions it was confirmed that Repeat is not universal to all
    alerts. So it's lifted out of the Base alert and re-inserted into those alerts
    where it should be present (namely Low and High alerts only).
    
    BACK-2554
    ewollesen committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    5775f56 View commit details
    Browse the repository at this point in the history
  3. adds activity tracking to alert configurations

    These activity properties will track the times at which alerts were sent,
    resolved, or acknowledged.
    
    BACK-2554
    ewollesen committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    cdda458 View commit details
    Browse the repository at this point in the history
  4. adds auth endpoint to retrieve a user's device tokens

    This endpoint will be used by upcoming changes to the auth client to allow
    care partner backend processes to retrieve device tokens in order to send
    mobile device push notifications.
    
    BACK-2554
    ewollesen committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    f10bf84 View commit details
    Browse the repository at this point in the history
  5. adds the ability to retrieve device tokens to the auth client

    This functionality will be used by care partner processes to retrieve device
    tokens in order to send mobile device push notifications in response to care
    partner alerts being triggered.
    
    BACK-2554
    ewollesen committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    fdce5dc View commit details
    Browse the repository at this point in the history
  6. remove unused device tokens repo from data

    This was missed when moving device tokens from the data service to the auth
    service in commit a0f5a84.
    
    BACK-2554
    ewollesen committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    2b77a38 View commit details
    Browse the repository at this point in the history
  7. adds a pusher client for sending APNs push notifications

    Basic steps are taken to allow for other push notification services to be
    easily added in the future.
    
    BACK-2554
    ewollesen committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    c7e19c1 View commit details
    Browse the repository at this point in the history
  8. adapts sarama.Logger to implement log.Logger

    So that sarama log messages better follow our standards, and will be emitted
    as JSON when log.Logger is configured for that.
    
    Before this change, the sarama logs were printed in plain-text without any of
    the benefits of the platform log.Logger.
    
    BACK-2554
    ewollesen committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    9213107 View commit details
    Browse the repository at this point in the history
  9. adapts go-common's asyncevents.SaramaEventsConsumer for alerts

    The existing FaultTolerantConsumer isn't used because it's retry semantics are
    hard-wired and aren't compatible with what care partner alerting's needs.
    
    Note: A proper implementation of AlertsEventsConsumer to consume events is yet
    to be written. It will follow shortly.
    
    BACK-2554
    ewollesen committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    2deaa47 View commit details
    Browse the repository at this point in the history
  10. allow invites to set an upload id

    The upload id is necessary to ensure that only the proper device data uploads
    are evaluated for care partner alert conditions.
    
    BACK-2554
    ewollesen committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    a31dd5c View commit details
    Browse the repository at this point in the history
  11. integrates an APNs pusher into data service

    If the necessary configuration isn't found, then push notifications will
    instead be logged.
    
    BACK-2554
    ewollesen committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    13dc4c6 View commit details
    Browse the repository at this point in the history
  12. adds Evaluate methods to alerts.Config

    These methods return Note objects that can be sent as push notifications.
    
    NotLooping evaluation will be handled in a later commit.
    
    BACK-2554
    ewollesen committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    b5141dc View commit details
    Browse the repository at this point in the history
  13. adds the alerts events consumer to the data service

    It uses the new asyncevents from go-common, as alerts processing requires
    different retry semantics than the existing solution.
    
    The Pusher interface is moved out of data/service into data/events to avoid a
    circular dependency.
    
    BACK-2554
    ewollesen committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    5053a69 View commit details
    Browse the repository at this point in the history
  14. remove some debugging logs

    No longer needed
    ewollesen committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    986106b View commit details
    Browse the repository at this point in the history

Commits on Jul 12, 2024

  1. add evaluation of not looping alerts

    BACK-2559
    ewollesen committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    d57125d View commit details
    Browse the repository at this point in the history