fix(avoid-mapping-selectors): allow ThisExpression in map (#287)

Resolves #285
timdeschryver · Mar 26, 2022 · a0a3d87 · a0a3d87
1 parent 0c7da0c
commit a0a3d87
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 1 deletion.
diff --git a/src/rules/store/avoid-mapping-selectors.ts b/src/rules/store/avoid-mapping-selectors.ts
@@ -44,7 +44,7 @@ export default createRule<Options, MessageIds>({
     )}[callee.object.callee.property.name='select']` as const
 
     return {
-      [`:matches(${selectSelector}, ${pipeWithSelectAndMapSelector}) > CallExpression[callee.name='map']`](
+      [`:matches(${selectSelector}, ${pipeWithSelectAndMapSelector}) > CallExpression[callee.name='map']:not(:has(ThisExpression))`](
         node: TSESTree.CallExpression,
       ) {
         context.report({

diff --git a/tests/rules/avoid-mapping-selectors.test.ts b/tests/rules/avoid-mapping-selectors.test.ts
@@ -114,6 +114,19 @@ export class CollectionService {
   }
 }
 `,
+  // https://github.com/timdeschryver/eslint-plugin-ngrx/issues/285
+  `
+import { Store } from '@ngrx/store'
+
+class OkBecauseOfThis {
+  foo$ = this.store.select(selectIsAuthenticated).pipe(
+      take(1),
+      map((isAuthenticated: boolean) => (isAuthenticated ? true : this.router.parseUrl('/login'))),
+  )
+
+
+  constructor(private store: Store) {}
+}`,
 ]
 
 const invalid: () => RunTests['invalid'] = () => [