-
Notifications
You must be signed in to change notification settings - Fork 220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC-1928: Clean up partials/configuration
directory
#3592
base: tinymce/7
Are you sure you want to change the base?
Conversation
@@ -11,7 +11,7 @@ As of {productname} 7.5.0, the default value of the `exportword_converter_option | |||
.**Default value:** | |||
[source,js] | |||
---- | |||
exportword_converter_options: { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please explain why you removed the exportword_converter_options
part in the example. I feel like in the current format was easier to understand with the exportword_converter_options
remaining. If the vision is to just say what the default value is maybe not having it a code snippet is easier possibly a sentence.
|
||
[NOTE] | ||
As of {productname} 7.5.0, the default value of the `importword_converter_options` setting has been updated to the following: | ||
|
||
.**Default value:** | ||
[source,js] | ||
---- | ||
importword_converter_options: { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similar question to the export_word. I'm just worried that it's a bit confusing to understand with no prior experience to remove that the function in the default value. I see that it's in the example so it's not hard for someone to put it together. If I could get an explanation to the idea of removing the function name, I'd really appreciate it :D
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall very good! Just got a question about removing the function names from the default values section
|
Ticket: DOC-1928
Site: Staging branch
I recreated the original PR and retained only the essential changes that are fixing something with factual inaccuracy or visual bug. This PR is oly 46 files with small changes in each, so it is easier to review. All changes in this PR have been visually checked for correction using a side-by-side comparison between
tinymce/7
andhotfix/7/DOC-1928_3
.Changes:
sidebar_show
code exampletypography_langs
type from Object to ArrayServian
toSerbian
false
type toanchor_bottom
andanchor_top
true
type toauto_focus
auto_focus: true
autoresize_bottom_margin
autoresize_overflow_padding
full
fortinycomments_access
content_css
custom_elements
custom_ui_selector
directionality
doctype
importword_converter_options
from String to Objectindentation
about the default valuefalse
type for insert_toolbar`mentions_selector
from Function to String and add default valuenonbreaking_force_tab
noneditable_regexp
from String to RegExpobject_resizing
pagebreak_separator
powerpaste_allow_local_images
powerpaste_html_import
resize
false
type for selection_toolbar`table_grid
tableofcontents_header
text_color.adoc
toolbar_mode
video_templete_callback
from String to FunctionPre-checks:
feature/<version>/
,hotfix/<version>/
,staging/<version>/
, orrelease/<version>/
.modules/ROOT/nav.adoc
has been updated(if applicable)
.release note
entry for anyNew product features
.productminorversion
inantora.yml
and added new supported versions entry inmodules/ROOT/partials/misc/supported-versions.adoc
.Review: