-
-
Notifications
You must be signed in to change notification settings - Fork 199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix default Token Format for Studio sync as DTCG #3264
base: main
Are you sure you want to change the base?
Conversation
|
|
Commit SHA:9ff392dd2973ef884e517a5a409739c18c617131 Test coverage results 🧪
|
Commit SHA:9ff392dd2973ef884e517a5a409739c18c617131 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this issue will be obsolote once you complete https://github.com/tokens-studio/studio-app/issues/2152 which will return them as DTCG
This issue does not appear to be particularly from studio sync, rather the tokenFormat persists the tokenFormat of the previous sync provider(or local), and if the previous one is legacy and then they choose studio sync, it sets to legacy regardless of the format it is receiving the tokens in |
Why does this PR exist?
Resolves #3259
What does this pull request do?
Currently, if the local storage or previous sync provider had tokens set in Legacy format, while switching to Tokens Studio Sync provider, it was being set to Leagcy as well, inspite of the tokens beign received from studio in DTCD format.
also, hides the badge of Legacy/DTCG in studio sync storage type as the default will always be DTCG
Testing this change
Additional Notes (if any)