Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump time crate #2990

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

kaffarell
Copy link
Contributor

Bumped the time crate to latest, they fixed some rust-nightly lint errors (time-rs/time#681).

Fixes: #2977

Note: this will also have to be backported to v0.1.x.

@kaffarell kaffarell requested review from hawkw, davidbarsky and a team as code owners May 31, 2024 12:14
@kaffarell kaffarell changed the title chore: bump time chore: bump time crate May 31, 2024
@coolbluewater
Copy link

Eagerly awaiting this fix...

@tomodachi94
Copy link

tomodachi94 commented Aug 14, 2024

Can you also update the time crate located in tracing-appender/Cargo.toml?

Bumped the time crate to latest, they fixed some rust-nightly lint
errors (time-rs/time#681).

Fixes: tokio-rs#2977
@kaffarell
Copy link
Contributor Author

Missed the one in tracing-appender. Should be complete now!

@flisky
Copy link

flisky commented Aug 20, 2024

I don't think this change is needed.
Because version = "0.3.2" means ^0.3.2, do a cargo update -p time will update Cargo.lock file and fixes this.
Accroding to https://github.com/time-rs/time#minimum-rust-version-policy, this will increase MSRV.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tracing-appender: Build error with rust-nightly: type annotations needed for Box<_>
5 participants