attributes: globally qualify attribute paths #3127
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoid ambiguities with any user-defined `tracing` modules by globally qualifying types used in the attribute-generated code e.g., `::tracing::Level`. Fixes: tokio-rs#3119
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid ambiguities with any user-defined
tracingmodules by globally qualifying types used in the attribute-generated code e.g.,::tracing::Level.Fixes: #3119 for the v0.1.x crate versions.
Motivation
We need to define helper functions for tracing within our own crates, and
tracingis too good a name to pass up. Our helpers will mostly wrap and otherwise "hide" thetracingcrate, but when using#[instrument]the generated code conflicts with ourtracingmodule.Solution
Globally qualify any token paths e.g.,
::tracingto avoid ambiguities.