fix: dont log for throwOnError when disabled (#657)

toonvanstrijp · Sep 9, 2024 · 434f37b · 434f37b
1 parent 764e5bb
commit 434f37b
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "nestjs-i18n",
-  "version": "10.4.7",
+  "version": "10.4.8",
   "homepage": "https://nestjs-i18n.com",
   "description": "The i18n module for Nest.",
   "author": "Toon van Strijp",

diff --git a/src/services/i18n.service.ts b/src/services/i18n.service.ts
@@ -113,6 +113,8 @@ export class I18nService<K = Record<string, unknown>>
       }" in "${lang}" does not exist.`;
       if (lang !== this.i18nOptions.fallbackLanguage || !!defaultValue) {
         if (this.i18nOptions.logging && this.i18nOptions.throwOnMissingKey) {
+
+          this.logger.error(translationKeyMissing);
           throw new I18nError(translationKeyMissing);
         }
 
@@ -126,7 +128,6 @@ export class I18nService<K = Record<string, unknown>>
         }
       }
 
-      this.logger.error(translationKeyMissing);
     }
 
     return (translation ?? key) as unknown as IfAnyOrNever<R, string, R>;