Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(crewai): initial instrumentation; collect agent and task traces #2489

Open
wants to merge 15 commits into
base: main
Choose a base branch
from

Conversation

adharshctr
Copy link

@adharshctr adharshctr commented Jan 7, 2025

  • I have added tests that cover my changes.
  • If adding a new instrumentation or changing an existing one, I've added screenshots from some observability platform showing the change.
  • PR name follows conventional commits format: feat(instrumentation): ... or fix(instrumentation): ....
  • (If applicable) I have updated the documentation accordingly.

image

@adharshctr adharshctr marked this pull request as ready for review January 7, 2025 11:42
@dosubot dosubot bot added size:XL This PR changes 500-999 lines, ignoring generated files. new instrumentation python Pull requests that update Python code labels Jan 7, 2025
@adharshctr
Copy link
Author

@nirga For my previous PR, i got some issue while resolving conflits. So i have to close that PR.
I have updated with the changes that you have suggested in my previous PR. Kindly review it. TIA!

@gyliu513
Copy link
Contributor

gyliu513 commented Jan 7, 2025

@adharshctr some tips for how to resolve conflict for some PRs:

How to resolve conflict: If git rebase has some conflict, then we need to resolve conflict as following:

Update files to resolve conflict
git add .
git rebase --continue
git commit --amend

@adharshctr
Copy link
Author

@adharshctr some tips for how to resolve conflict for some PRs:

How to resolve conflict: If git rebase has some conflict, then we need to resolve conflict as following:

Update files to resolve conflict
git add .
git rebase --continue
git commit --amend

Thank you

@gyliu513
Copy link
Contributor

Fixed #2339

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer new instrumentation python Pull requests that update Python code size:XL This PR changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants