Refactor and async/await #87
Commits on Dec 17, 2020
-
-
-
-
-
-
returning the promise is a backwards incompatible change
-
-
fix existing bug and its broken integration test
The "delete this._streams[name]" code not a good idea, because it causes a race condition: If the user calls createAssembly immediately after addFile, it throws correctly as per the test requirement. However if if there is a delay between calling addFile and createAssembly, the 'error' event is emitted after createAssembly can get _streams and _streams will be empty so createAssembly will not throw the expected error
-
-
-
-
-
-
-
-
Commits on Dec 21, 2020
-
-
parallellize tus upload and fix broken uploadProgress
the reduce code was broken and was giving only NaN thus uploadProgress never worked
-
Allow adding non-streams transloadit#86 transloadit#50
simplify and remove hacky logic (move file prop outside)
Commits on Dec 30, 2020
-
-
remove transpiling and unused modules
- set required node version to 10.0.0 - rename progressCb to onProgress (more consistent with tus) - Improve readme - add logo to readme 💅
-
remove duplicate .eslintrc file
(.eslintrc.js has precedence over .eslintrc)
-
Commits on Dec 31, 2020
-
remove incorrect code from readme
assembly errors are indeed thrown by the code
-
-
fix retry bug and add test for this
For some reason getAssembly did a retry on ALL errors this seems incorrect as it will cause calls to take unnecessarily long to execute, even though the assembly has completed (e.g. INVALID_FILE_META_DATA)
Commits on Jan 1, 2021
-
-
-
-
-
-
provide an actual working example under Usage and how to get started
-
-
-
-
Commits on Jan 3, 2021
Commits on Jan 6, 2021
-
-
-
-
-
-
run integration tests in series
Integration tests are not yet ready to run in parallel
-
fix test that caused jest to hang
it was not closing the server also make the test use async await
-
-
-
Commits on Jan 7, 2021
-
-
-
- Clarify strange deleteAssembly logic - Also fix a bug where it would use assembly_url instead of assembly_ssl_url (which was insecure and could be mitm attacked) - improve logging
-
-
unify error thrown upon existance of response.error
it made some tests unstable because sometimes it threw new Error(result.error)
-
-
-
Commits on Jan 8, 2021
-
Add more tests and remove retry
simplify retrying only retry RATE_LIMIT_REACHED now
-
-
-
Improve error handling and documentation (breaking)
- Add assembly id to assembly error messages - pass on GOT errors - `Error.error` renamed to `Error.transloaditErrorCode` - `Error.assembly_id` renamed to `Error.assemblyId` - **All other JSON response properties from Transloadit server are removed** from the `Error` object, but can now be found in `err.response.body`. rest of properties can be found on under err.response?.body (e.g. err.response?.assembly_id) - refer to official docs more - improve error documentation - change replayAssemblyAsync(opts) -> replayAssemblyAsync(assemblyId, params) - change replayAssemblyNotificationAsync(opts) -> replayAssemblyNotificationAsync(assemblyId, params) - rename deleteAssembly->cancelAssembly - fix broken notifyUrl
-
-
Commits on Jan 10, 2021
-
-
-
-
-
-
(json stringify is not needed) and improve readme
Commits on Jan 13, 2021
-
-
-
-
-
-
-
add timeout options and increase default timeout to 60s
- for createAssemblyAsync - default timeout for all requests
-
-
-
-
-
-
Commits on Jan 14, 2021
-
-
if calling createAssembly with a callback function now
-
-
-
-
Commits on Jan 15, 2021
-
return from polling instead of throwing error
if result.ok is not ASSEMBLY_UPLOADING or ASSEMBLY_EXECUTING
-
-
throw when createAssembly result contains "error" but 200
also change signature of awaitAssemblyCompletion
-
-
- throw on response.error also for replayAssembly - allow await replaying assembly completion - provide err.response.body also for errors thrown - improve readme
-
-
-
don't throw unknown error if result.ok is not set
this is not the task of the node-sdk
-
-
-
-
Commits on Jan 16, 2021
-
-
-
-
-
-
-
Remove undocumented fields option
directly under createAssembly it was a duplicated functionality of the fields inside params
-