-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify image naming and packaging #690
base: master
Are you sure you want to change the base?
Conversation
this updates the naming from opal, stevonnie, and sardonyx to the linux release + version additionally, we can now take advantage of GCE image family names
@@ -0,0 +1,211 @@ | |||
--- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: what about naming this file travis-ci-ubuntu-1604.yml
to go with the name of the sub directory in the cookbooks i.e. cookbooks/travis_ci_ubuntu_1604
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was mostly following the previous naming conventions, I can look into this renaming.
this removes the need for us to continuosly update the source image id
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have you attempted to build images with the current PR through travis-infrastructure/packer-build? Think successful image builds are necessary a necessary precondition to consider merging this.
About the approach itself, it is necessary to have at least two image stacks: A minimal one and a maximal one. The first is needed to bootstrap the larger one. The bootstrapping consists of compiling language archives (ruby,php,python,erlang,perl), which need to happen on the same distribution.
Currently, we have three stacks for Xenial, the minimal one (stevonnie), one with support of jvm,python,ruby,php (sardonyx), and one with support for perl,erlang.
It might make sense to combine these two larger stacks into one, but a separate small one remains necessary.
I'd suggest to not change existing stacks dramatically. I'd start with:
- making a minimal bionic image available
- compiling language archives
- make a decision what features should be available on bionic in general, and decide if they should be on one stack, or divided up onto two stacks
- depending on the decision, make one or more extra bionic stacks
I'd say changing the stack structure of existing ubuntu release is not the best use of time.
What is the problem that this PR is trying to fix?
This is a move towards a reduced set of images, and clearer image names. This also takes advantage of a feature call "image families", which means we always use the most up to date base image, and can use the feature to provide channels of images.