Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Xenial updates #730

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Xenial updates #730

wants to merge 2 commits into from

Conversation

DamianSzymanski
Copy link
Contributor

What is the problem that this PR is trying to fix?

What approach did you choose and why?

How can you test this?

What feedback would you like, if any?

@weekly-digest weekly-digest bot mentioned this pull request Nov 24, 2019
Open
@weekly-digest weekly-digest bot mentioned this pull request Dec 1, 2019
Open
michal-at-travisci
michal-at-travisci requested changes Dec 13, 2019
View reviewed changes
Copy link
Contributor

@michal-at-travisci michal-at-travisci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

node.js 8 should stay, updated to 8.16
we've got side by side two 2.5 rubies: 2.5.3 . and 2.5.7 - shouldn't it be only 2.5.7?
python 2.7 is EOL, but we should't remove it by April 2020 - last patch release is planned by then
See comments in file diff.

cookbooks/travis_ci_opal/attributes/default.rb Show resolved Hide resolved
cookbooks/travis_ci_opal/attributes/default.rb Show resolved Hide resolved
cookbooks/travis_ci_opal/attributes/default.rb Show resolved Hide resolved
cookbooks/travis_ci_sardonyx/attributes/default.rb Show resolved Hide resolved
cookbooks/travis_ci_sardonyx/attributes/default.rb Show resolved Hide resolved
cookbooks/travis_ci_stevonnie/attributes/default.rb Outdated Show resolved Hide resolved
@weekly-digest weekly-digest bot mentioned this pull request Dec 15, 2019
Open
@weekly-digest weekly-digest bot mentioned this pull request Dec 22, 2019
Open
@weekly-digest weekly-digest bot mentioned this pull request Feb 23, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@r-arek r-arek r-arek approved these changes

@michal-at-travisci michal-at-travisci Awaiting requested review from michal-at-travisci

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DamianSzymanski @michal-at-travisci @r-arek