Add the bluemixcloudfoundry deployment type #475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Adam King <[email protected]>
Set edge true for bluemixcloudfoundry deploy type to eliminate the manual step when using the CLI to generate .travis.yml Signed-off-by: Adam King <[email protected]>
edge no longer required for bluemixcloudfoundry. Remove it. Signed-off-by: Adam King <[email protected]>
|
Any update on this guy? Seems like a pretty straight forward PR. |
|
Can you tell me what does the bluemixcloudfoundry parameter edge do? It's mentioned in the documentation for some reason. |
|
@peterpoliwoda Would you include a link here? Sorry I don't see |
|
@adamkingit It's here, so I'm wondering what that param is because it actually broke my deployment https://docs.travis-ci.com/user/deployment/bluemixcloudfoundry/ |
|
IIRC it's used for new deployments before they are integrated. Seems we need to submit a PR to update the doc. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Adam King [email protected]