Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add endpoints as arguments #394

Merged
merged 1 commit into from
May 30, 2024
Merged

Add endpoints as arguments #394

merged 1 commit into from
May 30, 2024

Conversation

takuya-obata
Copy link
Contributor

  • add endpoints as arguments (workflow_monitoring)
  • add all table initialization process (cdp_monitoring)

- add endpoints as arguments (workflow_monitoring)
- add all table initialization process (cdp_monitoring)
@takuya-obata takuya-obata requested a review from a team as a code owner March 22, 2024 08:06
@takuya-obata
Copy link
Contributor Author

@o-mura -san
When I ran workflow_monitoring workflow in the JP environment, some tasks failed because the endpoints did not reflected as arguments, so I added the endpoints as arguments to those tasks.

And when journey did not exist, the initialization job did not create tables associated with journey, which caused errors when I ran the scheduled one.
So I added a process to the initialization job to create all empty tables.

It could be happy if you review these changes and approve the request. Thanks.

@o-mura
Copy link
Contributor

o-mura commented May 30, 2024

@takuya-obata
Thanks!

@o-mura o-mura merged commit d435d4f into master May 30, 2024
3 checks passed
@o-mura o-mura deleted the revised-obata branch May 30, 2024 02:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants