Close StatementClient when hitting client-side timeout #136
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Ensure sending a query cancel request when hitting client-side timeout.
Overview
StatementClient.close
sends a query cancel request but it doesn't work after hitting the client-side timeout because the internal state has been changed byraise_timeout_error!
whenclose
is called.In order to ensure sending a query cancel request, call
close
automatically before throwing the exception when hitting the client-side timeout.This is a port of trinodb/trino#24446
Checklist