Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use lakefs-enterprise in lakefs charts #314

Merged
merged 4 commits into from
Feb 10, 2025
Merged

Use lakefs-enterprise in lakefs charts #314

merged 4 commits into from
Feb 10, 2025

Conversation

N-o-Z
Copy link
Member

@N-o-Z N-o-Z commented Feb 5, 2025

closes #313

When fluffy is enabled use lakefs-enterprise image instead of OSS

@idanovo @Isan-Rivkin Not sure if the changes I made are the "right" way to do it. Let me know if this can be done better.

Tested manually

@N-o-Z N-o-Z self-assigned this Feb 5, 2025
@N-o-Z N-o-Z force-pushed the task/add-lakefs-enterprise-to-chart-313 branch from 0d59d52 to 30d9428 Compare February 5, 2025 22:12
Isan-Rivkin
Isan-Rivkin requested changes Feb 6, 2025
View reviewed changes
Copy link
Contributor

@Isan-Rivkin Isan-Rivkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. When tested manually did you test the "upgrade" scenario?

  1. Existing enterprise installation ( image: treeverse/lakefs + fluffy and all that)
  2. Helm upgrade to new version (image: treeverse/lakefs-enterprise)

@N-o-Z
Copy link
Member Author

N-o-Z commented Feb 6, 2025

Thanks. When tested manually did you test the "upgrade" scenario?

  1. Existing enterprise installation ( image: treeverse/lakefs + fluffy and all that)
  2. Helm upgrade to new version (image: treeverse/lakefs-enterprise)

Thanks for the review.
This was tested by using helm install in staging.
Once this will be approved I will try to run upgrade on our enterprise org

@N-o-Z N-o-Z requested a review from Isan-Rivkin February 6, 2025 18:28
Isan-Rivkin
Isan-Rivkin requested changes Feb 9, 2025
View reviewed changes
@Isan-Rivkin Isan-Rivkin self-requested a review February 10, 2025 18:03
Isan-Rivkin
Isan-Rivkin approved these changes Feb 10, 2025
View reviewed changes
Copy link
Contributor

@Isan-Rivkin Isan-Rivkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!!

@N-o-Z N-o-Z merged commit ee76f4e into master Feb 10, 2025
3 checks passed
@N-o-Z N-o-Z deleted the task/add-lakefs-enterprise-to-chart-313 branch February 10, 2025 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Isan-Rivkin Isan-Rivkin Isan-Rivkin approved these changes

@idanovo idanovo Awaiting requested review from idanovo

@guy-har guy-har Awaiting requested review from guy-har

Assignees

@N-o-Z N-o-Z

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add lakefs-enterprise to the lakefs chart
2 participants
@N-o-Z @Isan-Rivkin