Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Client main refactor #256

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

adam4813
Copy link
Member

Description

This is a refactor to organize and cleanup the main file. Additionally this fueled a desire to test against clang on MSVC, which led to updating the VCPKG baseline in an effort to fix protobuf (this failed), but this led to an update of IMGUI.

The IMGUI update is just a patch towards the correct fix of using the supplied backends:

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

- Updated `c_cpp_properties.json` with new "Win32" configuration and set `mergeConfigurations` to true.
- Modified `settings.json` to add new C/C++ settings for case sensitivity, error squiggles, and default standards.
- Added new hidden presets for Ninja Multi-Config with MSVC and Clang compilers in `CMakePresets.json`.
- Refactored `imgui-system.cpp`:
  - Initialized `inifilename` and `logfilename` with local constants.
  - Removed keyboard mapping setup.
  - Added `GlfwKeyToImGuiKey` function for key code mapping.
  - Updated `KeyboardEvent::On` function for robust key event handling.
  - Used `SetTexID` in `CreateDeviceObjects` and restored last bound texture.
- Changed C++ standard to C++20 in `helpers.cmake` for `add_program` and `add_interface_lib`.
- Updated `vcpkg.json` to new `builtin-baseline` commit hash.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant