Handle Uploading Impacted Targets From Forked PRs #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pv72895
changed the title
gnalh
approved these changes
Feb 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does The PR Do
This PR properly handles uploading impacted targets from forked PRs. This required some changes with how we check out branches from PRs - mainly, switching to the SHA instead of the ref/branch name
Testing
This was tested with two PRs using the most current SHA of this action (
7892141d5667431db80de9b7c8fd82378c7390bd) - one was forked, and one was notForked
Not forked
Other things done in the PR
I made it so that we also print out the response body from the API call to upload impacted targets if we don't get a 200 back, which should make it much clearer as to what went wrong