Skip to content
This repository has been archived by the owner on Sep 18, 2021. It is now read-only.

add support for balanced parens in query #120

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

markevaul
Copy link

add support for query containing and ending in balanced parens such as
http://www.example.com?q=(1,2)

add support for query containing and ending in balanced parens such as
http://www.example.com?q=(1,2)
@markevaul
Copy link
Author

I'd like to add some test cases to the conformance tests as well

http://www.example.com?q=(1,2) => http://www.example.com?q=(1,2)
(http://www.example.com?q=(1,2)) => http://www.example.com?q=(1,2)

@jakl
Copy link
Contributor

jakl commented Apr 28, 2014

Oh sweet, thanks!

@markevaul
Copy link
Author

The only issue i can think of with this fix is that I removed '(' and ')' from valid query characters, meaning that only balanced parens in query will be allowed. I'm not sure if this is an issue or not, but there are no unit tests that have parens in the query, other than the ones I added.

'\\(' +
'(?:' +
'#{validUrlQueryChars}+' +
'|' +
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you replace tab indentation with spaces in this line and alight plus signs on the right in this whole expression?

@jakl
Copy link
Contributor

jakl commented Apr 28, 2014

That sounds fair since we're already into balancing parens.

@@ -304,7 +325,7 @@
'(#{validDomain})' + // $5 Domain(s)
'(?::(#{validPortNumber}))?' + // $6 Port number (optional)
'(\\/#{validUrlPath}*)?' + // $7 URL Path
'(\\?#{validUrlQueryChars}*#{validUrlQueryEndingChars})?' + // $8 Query String
'(\\?#{validUrlQuery})?' + // $8 Query String
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here – align plus sign and the comment with the comments above, please.

@CLAassistant
Copy link

CLAassistant commented Nov 16, 2019

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants